Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add terminal screencast #205

Merged
merged 1 commit into from
Mar 8, 2024
Merged

docs: add terminal screencast #205

merged 1 commit into from
Mar 8, 2024

Conversation

katexochen
Copy link
Member

No description provided.

@katexochen katexochen requested a review from m1ghtym0 March 7, 2024 09:20
@m1ghtym0
Copy link
Member

m1ghtym0 commented Mar 7, 2024

cast lgtm:-)
Playback speed and "pause threshold" is controlled by the player, so nothing to be done here.
If we want to scroll the manifest content slowly, we have to do it in bash directly. But IMO there's no need the cast should just give a feeling and impression.

@katexochen katexochen marked this pull request as ready for review March 8, 2024 09:30
@katexochen
Copy link
Member Author

We'll need to build additional integration of screencast generation into our release workflow, not required for this PR.

@katexochen katexochen requested a review from 3u13r March 8, 2024 09:31
Copy link
Member

@3u13r 3u13r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@katexochen katexochen merged commit bc1c505 into main Mar 8, 2024
6 checks passed
@katexochen katexochen deleted the p/cast branch March 8, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants